kicad-developers team mailing list archive

[Chris Morgan <chmorgan@xxxxxxxxx>]

On Mon, Jun 10, 2013 at 8:29 AM, Dick Hollenbeck <dick@xxxxxxxxxxx> wrote:

> >
> > Can you test the attached patch:
> > It removes the if( ..) useless test (and perhaps broken) which explains
> > sometimes the panning does not happen.
> > It set the cross hair position before sending the event which uses this
> > position, and ensure the zoom center does not uses a strange previous
> > position.
>
>
> It works, and I like it for the short lived time
>
>    void EDA_DRAW_PANEL::OnMouseLeaving( wxMouseEvent& event )
>
> will likely last (until solutions to a) or b) arrive).
>
>
> I have asked Chris to remove the goofy event dispatching mechanism, and
> simply call member
> function(s), and that would wrap up my last concern beyond a) and b).
>
>
Oh, I hadn't entirely grasped that from reading your email and haven't gone
back to read it since a busy weekend.

I take it you mean the removing the dispatching of the dialog menu zoom
center message? It would certainly make the code simpler to just move the
viewport around via a direct call. One of my questions on the block
centering having to taint the zoom centering with knowledge of block
dragging but direct calls would allow that to be separated out cleanly.

Chris