kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxxxx>]

On 8/3/2013 7:13 PM, Cirilo Bernardo wrote:
> ----- Original Message -----
>
> > From: Wayne Stambaugh <stambaughw@xxxxxxxxxxx>
> > To: kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Cc:
> > Sent: Sunday, August 4, 2013 4:59 AM
> > Subject: Re: [Kicad-developers] USE_PCBNEW_NANOMETRES
> >
> > On 8/3/2013 2:52 PM, Dick Hollenbeck wrote:
> > >   Can any one see a reason not to yank this conditional, and make its enabled
> > code the norm?
> >
> > I can't think of one.  Now as good a time as any.  Hopefully no one is
> > still building KiCad with USE_PCBNEW_NANOMETRES=OFF.
>
>
> Is it worthwhile forcing a CMake error if someone does define it off?

I think this was written with the intention of removing it completely 
from the code once nanometer support was stable.  Getting rid of all of 
the ugly #if define(USE_PCBNEW_NANOMETRES)/#endif from the source code 
should be the goal so making CMake force an error wouldn't server any 
purpose.

> - Cirilo
>
> > >   It seems as good as old school now.
> > >
> > >   Dick