kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxxxx>]

On 11/12/2013 9:12 AM, Константин Барановский wrote:
> Hello!
> 
> I fixed vertical justification of the rotated or mirrored text.
> Patch was attached.
> 
> Regards,
> Konstantin.

Konstantin,

Are you sure this patch is correct?  You now have two calls to
RotatePoint().  One inside of #ifdef FIX_MULTILINE_VERT_JUSTIF/#endif
and one immediately following the #endif.  It may work properly but from
programmer's perspective it is confusing.  It seems to me that you
should be able to do it with a single call to RotatePoint().  If you
must call RotatePoint() twice, please add a comment to explain why you
need both so the next developer can figure out why you did it that way.

Wayne

> 
> 
> 2013/10/25 jp charras <jp.charras@xxxxxxxxxx <mailto:jp.charras@xxxxxxxxxx>>
> 
>     Le 24/10/2013 23:03, Барановский Константин a écrit :
>     > Currently alignment of the multiline text applied only for first line
>     > and other lines just plased under it.
>     > Attached patch allows to align the multiline text given the all
>     lines of
>     > the text.
>     >
>     > --
>     > Baranovskiy Konstantin
> 
>     Thanks.
> 
>     I added your patch with some other fixes.
> 
>     --
>     Jean-Pierre CHARRAS
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>