kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #12244
Patch: don't hardcode wxPython path
The recent addition of CMakeModules/download_wxpython.cmake has resulted in
build failures. The main cause is the fact the --prefix option passed to
the configure script of wxPython is hardcoded to /Users/marco/
Development/product/libwxpython_root. The attached patch replaces that with
the appropriate CMake variable, ${LIBWXPYTHON_ROOT}. This fixes the build
for me.
The additional system dependencies for this also need to be documented. On
Ubuntu 13.04, I needed to install the libgstreamer-plugins-base0.10-dev
package to get a pkg-config file so the wxPython build could find the
system install of gstreamer; this is a required dependency for the build to
succeed.
To the limited extent of my testing, KiCad had been compiling fine with the
system copies of wxPython and swig. Is there now a need for this to be
built locally in all cases, or can it be dependent on the OS or some other
set of conditions?
Regards,
Blair
=== modified file 'CMakeModules/download_wxpython.cmake'
--- CMakeModules/download_wxpython.cmake 2014-02-07 22:00:19 +0000
+++ CMakeModules/download_wxpython.cmake 2014-02-08 05:12:38 +0000
@@ -74,7 +74,7 @@
UPDATE_COMMAND ${CMAKE_COMMAND} -E remove_directory "${LIBWXPYTHON_ROOT}"
COMMAND ${LIBWXPYTHON_EXEC} wxPython/build-wxpython.py --clean
- CONFIGURE_COMMAND ${LIBWXPYTHON_EXEC} wxPython/build-wxpython.py --prefix=/Users/marco/Development/product/libwxpython_root --unicode --install ${LIBWXPYTHON_OPTS}
+ CONFIGURE_COMMAND ${LIBWXPYTHON_EXEC} wxPython/build-wxpython.py --prefix=${LIBWXPYTHON_ROOT} --unicode --install ${LIBWXPYTHON_OPTS}
#BINARY_DIR "${PREFIX}"
Follow ups