kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #13075
Re: [PATCH] Fix vertical offset for multiline text in VRML exporter
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
jp charras <jp.charras@xxxxxxxxxx>
-
Date:
Sat, 19 Apr 2014 18:06:43 +0200
-
In-reply-to:
<CAOuK9LgqcX7buZXeWGUtXgPXQ9zz+kW8J=OReS9jrar-sbTJZQ@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
Le 15/04/2014 16:45, Nick Østergaard a écrit :
> Greetings
>
> After the fuzz with the multiline text's origin [1], this was not
> fixed in the VRML export, maybe also some other exporters, I have not
> tried those.
>
> Here is a patch that applies the same method to the export_vrml.cpp as
> was done in rev 4577.
>
> I am not sure if the (EDA_COLOR_T) cast should be there or not, I
> guess not. I also indented the arguments of the function calls around
> that area. I can't see exactly in the style guide if this is how it is
> supposed to be, but that is how it is done in almost all the other
> places I have looked.
>
> I have tested this by importing to blender.
>
> Regards
> Nick Østergaard
>
> [1] https://bugs.launchpad.net/kicad/+bug/1263798
Committed, Thanks.
--
Jean-Pierre CHARRAS
References