kicad-developers team mailing list archive

[Dick Hollenbeck <dick@xxxxxxxxxxx>]

On 04/15/2014 09:45 AM, Nick Østergaard wrote:
> Greetings
> 
> After the fuzz with the multiline text's origin [1], this was not
> fixed in the VRML export, maybe also some other exporters, I have not
> tried those.
> 
> Here is a patch that applies the same method to the export_vrml.cpp as
> was done in rev 4577.
> 
> I am not sure if the (EDA_COLOR_T) cast should be there or not, I
> guess not. I also indented the arguments of the function calls around
> that area. I can't see exactly in the style guide if this is how it is
> supposed to be, but that is how it is done in almost all the other
> places I have looked.


Wayne likes it that way.  I don't.  A year ago I changed uncrustify.cfg to use the former.
 Either are acceptable to me, but with that approach, I find it eats too much whitespace
and forces stuff too far to the right.

Two tabs are what I use typically.  This is a non-issue for this patch, since both are
acceptable.

I am not evaluating the patch.



> 
> I have tested this by importing to blender.
> 
> Regards
> Nick Østergaard
> 
> [1] https://bugs.launchpad.net/kicad/+bug/1263798
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>