← Back to team overview

kicad-developers team mailing list archive

Re: Suspicious layer parameter in PNS_SHOVE::pushVia

 

On Sun, May 18, 2014 at 11:17:59PM +0200, Tomasz Wlostowski wrote:
> For the moment it's irrelevant, the router only supports through vias (so
> any layer will work)

At least we're sure that we feed the compiler the right stuff... strict
type checking needs a good value, so it's better if it's already the
best one available.

Another thing: in the ROUTER_PREVIEW_ITEM m_layer and m_originLayer are
intended as GAL_LAYERs or as pcbnew layers (LAYER_NUMs)? I'd say
GAL_LAYERs, from the constructor, but until now they were used as
LAYER_NUMs (of course GAL_LAYER is a superset of LAYER_NUM, so it would
be correct, just a wrong previous assumption of mine).

(...feeling the lack of PASCAL/Modula/ADA typing and NIL in C++...and
too much (implicit) conversion rules to worry about)

-- 
Lorenzo Marcantonio
Logos Srl


References