kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 26/05/2014 22:57, Cirilo Bernardo a écrit :
> ----- Original Message -----
> 
>> From: jp charras <jp.charras@xxxxxxxxxx>
>> To: Cirilo Bernardo <cirilo_bernardo@xxxxxxxxx>; KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> Cc: 
>> Sent: Tuesday, May 27, 2014 4:20 AM
>> Subject: Re: [Kicad-developers] update on IDF tools and patch
>>
>> Le 25/05/2014 03:15, Cirilo Bernardo a écrit :
>>
>>>  Hi folks,
>>>
>>>   The latest IDF code has been checked for coding style and tested
>>>  for bugs. The patch I created will only make changes to the
>>>  utils/idftools directory, so it's safe to include in the main branch
>>>  and won't affect the rest of KiCad at all.
>>>
>>>   The code is currently used only for the various IDF tools, but I
>>>  intend to rewrite the IDF export code and VRML export code to make
>>>  use of this new(er) codebase; among other things this newer codebase
>>>  fixes a number of bugs which I have found in the VRML and IDF
>>>  export code.
>>>
>>>   I would appreciate some comments on what to do with this code in
>>>  the future. I would like to see it compiled as a shared library so that
>>>  the VRML and IDF exporter as well as the IDF tools can make use of it
>>>  without the bloat of static libraries.  Since the code will only be
>>>  common to the pcbnew exporters and the IDF tools, I thought that the
>>>  IDF framework code would be best placed in an 'idf' directory in 
>> the
>>>  top of the source tree if/when it is finally included in KiCad.
>>>
>>>   In principle the new IDF code will also make it pretty easy to add an
>>>  IDF importer, but since no one has requested such a tool and I don't
>>>  need it, I haven't bothered to write such a thing.
>>>
>>>   I tried to build and link the IDF code as a shared library but the
>>>  linking of idf2vrml failed with undefined references; after banging my
>>>  head on the desk wondering why cmake wasn't doing what I expected it 
>> to,
>>>  I gave up and built as STATIC. If anyone can see what I've been doing
>>>  wrong I'd appreciate some feedback on that.
>>
>> Thanks, Cirilo.
>>
>> I have an issue with the macro ERROR, which conflicts with an other
>> system macro.
>>
>> May I ask you to change its name to ERROR_IDF, or something else.
>>
>> Thanks.
>>
>>
>> -- 
>> Jean-Pierre CHARRAS
>>
> 
> Thanks Jean-Pierre,  the macro name has been changed to ERROR_IDF in the latest patch.
> 
> - Cirilo
> 

Committed, with a fix for Windows compatibility.

-- 
Jean-Pierre CHARRAS