kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 03/08/2014 03:24, Martin Janitschke a écrit :
> Heyho,
> please feel free to test and apply the attached patch for the 3D viewer.
> 
> It'll enable anti-aliasing - if the renderer supports it with up to
> factor 8 (beyond this there was no difference in the subtracted images).
> The code also deals with the possible changes to the attributes array
> (avoiding fixed indices).
> 
> For the results see http://imgur.com/a/TgaXT .
> 
> Bye,
> imp

Thanks for your patch.

However it has a potential bug in loops:
for( ii = 0; ii < sizeof( attrs ); ii += 2)
does not stop the iteration at the end of the table.

and the code expects  WX_GL_SAMPLES is the last item in attrs table,
which is currently true, but could be modified later (and there is no
comment to explain this constraint).

-- 
Jean-Pierre CHARRAS