kicad-developers team mailing list archive

[Dick Hollenbeck <dick@xxxxxxxxxxx>]

On 08/11/2014 07:51 PM, Andrew Zonenberg wrote:
> Hi all,
> 
> I submitted a merge request a week or two ago via Launchpad:
> https://code.launchpad.net/~azonenberg/kicad/advanced-feature-bugfixes/+merge/229341
> 
> Orson and Wayne both commented on it with some minor concerns related to
> #ifdefs and code formatting. I pushed an updated version a few hours
> later addressing their concerns. Orson told me via IRC that he's fine
> with the updated code, and that's the last I've heard from anyone.
> 
> Are you guys just too busy to look at it right now? Did it get
> misplaced/forgotten? Are there any other issues with my code that
> nobody's told me about? It's not exactly urgent, but I'd like to get it
> merged eventually.
> 
> Thanks :)


Probably too busy.

line 41 of this:

https://code.launchpad.net/~azonenberg/kicad/advanced-feature-bugfixes/+merge/229341

is showing one indent level on a switch(), and this is incorrect.  Case statements are at
the same indent level as the switch().

 switch( m_CoordIndex[idx].size() )
40	{
41	case 3: glBegin( GL_TRIANGLES );break;
42	case 4: glBegin( GL_QUADS ); break;
43	default: glBegin( GL_POLYGON ); break;
44	}


Email formatting is not reliable here.

I am not taking any responsibility for committing it.   But this is one obvious deficiency.


You did good reminding those that have already commented.