kicad-developers team mailing list archive

[Andrew Zonenberg <azonenberg@xxxxxxxxxxxxxxx>]

Hmm, let me take a look at the existing code. I'm pretty sure that was
already there, since all I did was indent the entire block by one level
and put the OpenMP pragma around it.

In any case, I'll fix it.

On Mon, 2014-08-11 at 20:43 -0500, Dick Hollenbeck wrote:
> On 08/11/2014 07:51 PM, Andrew Zonenberg wrote:
> > Hi all,
> > 
> > I submitted a merge request a week or two ago via Launchpad:
> > https://code.launchpad.net/~azonenberg/kicad/advanced-feature-bugfixes/+merge/229341
> > 
> > Orson and Wayne both commented on it with some minor concerns related to
> > #ifdefs and code formatting. I pushed an updated version a few hours
> > later addressing their concerns. Orson told me via IRC that he's fine
> > with the updated code, and that's the last I've heard from anyone.
> > 
> > Are you guys just too busy to look at it right now? Did it get
> > misplaced/forgotten? Are there any other issues with my code that
> > nobody's told me about? It's not exactly urgent, but I'd like to get it
> > merged eventually.
> > 
> > Thanks :)
> 
> 
> Probably too busy.
> 
> line 41 of this:
> 
> https://code.launchpad.net/~azonenberg/kicad/advanced-feature-bugfixes/+merge/229341
> 
> is showing one indent level on a switch(), and this is incorrect.  Case statements are at
> the same indent level as the switch().
> 
>  switch( m_CoordIndex[idx].size() )
> 40	{
> 41	case 3: glBegin( GL_TRIANGLES );break;
> 42	case 4: glBegin( GL_QUADS ); break;
> 43	default: glBegin( GL_POLYGON ); break;
> 44	}
> 
> 
> Email formatting is not reliable here.
> 
> I am not taking any responsibility for committing it.   But this is one obvious deficiency.
> 
> 
> You did good reminding those that have already commented.
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

-- 
Andrew Zonenberg
PhD student, security group
Computer Science Department
Rensselaer Polytechnic Institute
http://colossus.cs.rpi.edu/~azonenberg/

Attachment: signature.asc
Description: This is a digitally signed message part