kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #14418
Re: PATCH: remove legacy EMP output from bitmap2component tool
Le 21/08/2014 08:07, Cirilo Bernardo a écrit :
> I've attached a tarball for patching bitmap2component. The
> tarball has a patch for:
>
> + modifications to bitmap2cmp_gui.cpp
> + modifications to bitmap2component.cpp
> + add file bitmap2component.h
>
> Also included as separate files are the wxFormBuilder file
> and its generated output files:
>
> bitmap2cmp_gui_base.fbp
> bitmap2cmp_gui_base.cpp
>
> bitmap2cmp_gui_base.h
>
> This patch set:
>
> 1. removes the legacy EMP file option
>
> 2. enforces case-sensitive extensions:
> Since our file filter dialogs are case-sensitive and
> dialogs generally do not have the all files wildcard
> in the filter list, I have enforced case-sensitive
> extensions for all the output files. PostScript files
> will now have '.ps' appended if the user supplied name
> does not end in '.ps', module files will end in
> '.kicad_mod', schematic files in '.lib' and logo files
> in '.kicad_wks'.
>
> The handling of cases has also been made more consistent
> by the removal of case statements with numerical constants
> (for example. 'case 4:') to improve readability and
> maintainability.
>
> - Cirilo
Committed.
Thanks.
--
Jean-Pierre CHARRAS
References