kicad-developers team mailing list archive

[Nick Østergaard <oe.nick@xxxxxxxxx>]

I just tried a clean build (removing the contents of my intree build
folder) with Ashley's patch on Archlinux. Worked fine, cmake did not
fail and the build succeeded. But it also seems like the variable was
set. The CMakeCache.txt contains;

OPENGL_INCLUDE_DIR:PATH=/usr/include

Just some feedback from my end.

2014-12-15 20:00 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
> Your patch breaks the CMake configuration on windows (and I suspect
> Linux and OSX as well).  The addition of "${OPENGL_INCLUDE_DIR}" to the
> utils/idftools/CMakeList.txt file is the problem.  It expands to an
> empty string on windows causing CMake to exit with and error.  If I
> remove the double quotes, everything builds fine.  Please test this on
> your system to see if it still builds without the double quotes.  A
> solution will have to be found that builds on FreeBSD without breaking
> existing builds before this patch can be added to kicad.
>
> On 12/12/2014 8:56 AM, Ashley Mills wrote:
>> Hi there,
>>
>> This is a patch for building on FreeBSD 10.1. Note config options are
>> as follows:
>>
>> cmake ../
>> -DwxWidgets_CONFIG_EXECUTABLE=/usr/local/bin/wxgtk2u-3.0-config
>> -DKICAD_SKIP_BOOST=YES
>>
>> Cheers
>>
>> Ashley
>>
>> === modified file 'include/kiway.h'
>> --- include/kiway.h   2014-11-15 13:43:23 +0000
>> +++ include/kiway.h   2014-12-09 22:13:10 +0000
>> @@ -114,7 +114,7 @@
>>  // be mangled.
>>  #define KIFACE_INSTANCE_NAME_AND_VERSION   "KIFACE_1"
>>
>> -#if defined(__linux__)
>> +#if defined(__linux__) || defined(__FreeBSD__)
>>   #define LIB_ENV_VAR    wxT( "LD_LIBRARY_PATH" )
>>  #elif defined(__WXMAC__)
>>   #define LIB_ENV_VAR    wxT( "DYLD_LIBRARY_PATH" )
>>
>> === modified file 'utils/idftools/CMakeLists.txt'
>> --- utils/idftools/CMakeLists.txt     2014-10-02 23:03:52 +0000
>> +++ utils/idftools/CMakeLists.txt     2014-12-09 22:13:43 +0000
>> @@ -1,6 +1,7 @@
>>  include_directories(
>>      "${CMAKE_SOURCE_DIR}/lib_dxf"
>>      "${CMAKE_SOURCE_DIR}/utils/idftools"
>> +    "${OPENGL_INCLUDE_DIR}"
>>    )
>>
>>  link_directories(
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp