← Back to team overview

kicad-developers team mailing list archive

Re: The library tables wizard

 

Ok, I see you have fixed it in rev 5371.

But I still see two semicolons in github/github_getliblist.cpp  I
don't see why there are two.

2015-01-15 22:57 GMT+01:00 Nick Østergaard <oe.nick@xxxxxxxxx>:
> Ahh, I just found the place. I have attached a patch that removed the
> extra slash and the extra semicolon.
>
> This interface looks much nicer to choose from instead of the browser window. :)
>
> Also, on the same dialog/form as the "Github Libs List" the button
> called "Add FP Library entry" does nothing.
>
> 2015-01-15 22:50 GMT+01:00 Nick Østergaard <oe.nick@xxxxxxxxx>:
>> Hi Jean-Pierre
>>
>> To me it seems like you have a double semicolor on
>> pcbnew/github/github_getliblist.cpp
>> 104    wxString urlPrefix = wxT( "https://"; ) + repo.GetServer() + wxT( "/" );;
>>
>> Aslo I geth the following error when trying to fetch. The problem is
>> the two slashes before repos. I could not figure out where those two
>> slashes come from, therefore I have not attached a patch.
>>
>> https GET command failed
>> Cannot get/download json data from:
>> 'https://api.github.com/orgs/KiCad//repos?per_page=99&page=1'
>> Reason: 'Not found'
>>
>> 2015-01-15 21:26 GMT+01:00 Miguel Ángel Ajo <majopela@xxxxxxxxxx>:
>>> As I said on the other email, awesome :-)
>>>
>>> I’m glad my advice made any sense. And I like your
>>> idea of being able to make a local copy via the KiCad plugin,
>>> that’s very nice.
>>>
>>>
>>> Miguel Ángel Ajo
>>>
>>> On Thursday, 15 de January de 2015 at 21:10, jp charras wrote:
>>>
>>> Le 07/01/2015 23:38, Miguel Ángel Ajo a écrit :
>>>
>>>
>>> Hi Jean Pierre, just an idea for your wizard work:
>>>
>>> https://api.github.com/orgs/KiCad/repos
>>>
>>> You could save the need to work with the HTML viewer and pagination problems
>>> using the above API endpoint, all the KiCad project repositories are listed
>>> into it
>>> in json format.
>>>
>>> Best regards,
>>>
>>> Miguel Ángel Ajo
>>>
>>>
>>> Your advices are always golden.
>>>
>>> I added some enhancements to the fp lib table wizard:
>>> a button to import and display the full list of these .pretty libs on
>>> github (using this URL).
>>> * if the current select plugin is the github plugin, one can select some
>>> of these libraries and add them to the current table.
>>> * if the current select plugin is the kicad plugin, one can select some
>>> of these libraries and download them to make a local copy (which is the
>>> usual way of work) in corresponding .pretty folders.
>>> They can added later to the table after they are downloaded.
>>>
>>> Testers are welcome
>>>
>>>
>>> --
>>> Jean-Pierre CHARRAS
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help : https://help.launchpad.net/ListHelp
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>


References