kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #16998
Fix (OS X) / Cleanup (all) Default Env Variables
Hi,
default paths for KISYSMOD/KISYS3DMOD are currently broken on OS X (set to same as for other OSes).
Attached patch
* OS X: Fixes default KISYSMOD/KISYS3DMOD (#ifdef typo)
* OS X: Removes setting KIGITHUB from kicad/pcbnew Info.plist in favor of hardcoded default setting
* Removes now unneeded Set3DShapesDefaultPath() and other small things
Attachment:
default-paths.patch
Description: Binary data
Removing Set3DShapesDefaultPath() seems to be OK for OS X and I guess it is also no longer needed for other OSes, but please double-check that.
Note:
I intentionally did not use __WXMAC__ but __APPLE__ in config.h as __WXMAC__ possibly might not yet be defined (by some wxWidgets include) when including config.h (although it seems as if cmake compiles all files using -D__WXMAC__, so it should be defined everywhere).
Regards,
Bernhard
PS:
Just in case, maybe it saves somebody some time… it took me almost a day to find out that my code changes in fact did work, but the old/wrong values have been written to KiCad preferences and have been taken from there overriding the new hardcoded default values...
Follow ups