kicad-developers team mailing list archive

[Cirilo Bernardo <cirilo.bernardo@xxxxxxxxx>]

A previous fix to bugs reported by Coverity resulted in a regression;
some lines of code originally did not have the intended effect and
I corrected that but the intended effect was in fact the wrong effect.
(Two wrongs do make a right!)

- Cirilo

=== modified file 'pcbnew/exporters/export_vrml.cpp'
--- pcbnew/exporters/export_vrml.cpp	2015-03-03 10:50:50 +0000
+++ pcbnew/exporters/export_vrml.cpp	2015-04-09 21:47:49 +0000
@@ -893,7 +893,6 @@
         const CPOLYGONS_LIST& poly = zone->GetFilledPolysList();
         int nvert = poly.GetCornersCount();
         int i = 0;
-        bool cutout = false;
 
         while( i < nvert )
         {
@@ -916,13 +915,7 @@
                 ++i;
             }
 
-            // KiCad ensures that the first polygon is the outline
-            // and all others are holes
-             vl->EnsureWinding( seg, cutout );
-
-             if( !cutout )
-                 cutout = true;
-
+             vl->EnsureWinding( seg, false );
             ++i;
         }
     }