← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] fix for bug in IDF exporter

 

Le 25/05/2015 09:15, Cirilo Bernardo a écrit :
> The IDF code has a bug in the calculation of the outlines winding direction
> and there is a possibility that strange shaped board outlines such as
> a crescent (2 arcs), pac-man (1arc, 2 lines), or a modified pac-man with
> 1 arc and 3 lines can result in the wrong winding being calculated. I could
> not trigger the bug with my hand-crafted outlines but I thought I may as
> well fix the bug before it is triggered by a user who requires a strange
> shaped board.
> 
> The VRML exporter also requires the winding calculations but it is immune
> to the bug since all arcs are approximated by line segments; the IDF
> code is vulnerable since arcs are treated as line segments between the
> start and end of the arc, which is obviously wrong.
> 
> - Cirilo

Committed. thanks.


-- 
Jean-Pierre CHARRAS


References