kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Chris,

I'm not sure what your proposing.  This code is fairly well designed and
very easy to understand and modify which was one of the original design
goals.  The s-expr tokens are well defined and immutable for each file
format and are automatically generated from a text file containing a
list of the tokens.  The only thing that varies is parsing of none token
values such as numbers.  I need some examples of what changes you are
proposing before I would be willing to give you the go ahead.

Cheers,

Wayne

On 6/1/2015 12:29 AM, Chris Pavlina wrote:
> Hi,
> 
> I've been having a look through some of the file I/O code in pcbnew, and
> I'm not really comfortable with it. Despite the nice new structured
> s-exp format, we're still printing data out by hand and parsing it back
> in similarly - rather a recipe for trouble, and at least for
> inconsistent files. I'd like to put in some work after the release to
> refactor this into a self-contained, data-agnostic S-expression
> parser/writer library. This should make it easier to consistently
> continue using the format later in the planned eeschema work. Also, it
> should significant reduce the risk of errors being introduced in read
> and write, since everything involving "dirty" external data will be
> contained in one place.
> 
> Anyone object to this, or have thoughts to contribute? Obviously it
> shall continue to read and write the exact same format, no format changes.
> 
> -- 
> Chris
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp