← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] GAL arc-drawing crash

 

Hi Chris,

I could not reproduce the assert, but your patch surely will not harm
the code, so there are chances it is going to work better. Thank you, I
committed your changes in revision 5695.

Regards,
Orson

On 06/02/2015 05:44 PM, Chris Pavlina wrote:
> In GAL, an assertion (drawing_tool.cpp:925) will fail if you begin 
> drawing an arc, and then accidentally terminate the arc at zero angle 
> with the cursor /outside/ the arc radius. It seems that an attempt was 
> made to check for this but the conditional wasn't written quite right. 
> Here's a patch to fix the conditional and correctly cancel terminating 
> the arc instead.
> 
> --
> Chris
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups

References