← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] GAL arc-drawing crash

 

It seems to me that it should be 100% reproducible, but there's only one specific way to trigger it, perhaps you're not doing it right? Here's what I did:

1. In GAL, select the arc tool.
2. Click to set the midpoint.
3. Move directly left to set the radius and startpoint.
4. Move directly left from there, so that the angle is zero, the mouse click is outside the arc radius, and the center, startpoint and click point are collinear.
5. Click to end the arc.

AFAIK putting the click-point inside the radius works too, but the three must be perfectly collinear and the click-point must not be *on* the arc.

On Tue, Jun 02, 2015 at 08:19:46PM +0200, Maciej Sumiński wrote:
Hi Chris,

I could not reproduce the assert, but your patch surely will not harm
the code, so there are chances it is going to work better. Thank you, I
committed your changes in revision 5695.

Regards,
Orson

On 06/02/2015 05:44 PM, Chris Pavlina wrote:
In GAL, an assertion (drawing_tool.cpp:925) will fail if you begin
drawing an arc, and then accidentally terminate the arc at zero angle
with the cursor /outside/ the arc radius. It seems that an attempt was
made to check for this but the conditional wasn't written quite right.
Here's a patch to fix the conditional and correctly cancel terminating
the arc instead.

--
Chris



_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp







References