← Back to team overview

kicad-developers team mailing list archive

Re: Eeschema toolbar button padding.

 

On 6/20/2015 3:51 AM, jp charras wrote:
> Le 20/06/2015 00:19, Nick Østergaard a écrit :
>> It looks like they were added by JPC in rev 3119.
>>
>> 2015-06-20 0:14 GMT+02:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
>>> Someone added the following code to all of the Eeschema toolbars:
>>>
>>> SetToolBorderPadding(2); // padding
>>> SetToolSeparation(0);
>>>
>>> but none of the other app window toolbars have this (pcbnew, gerbview,
>>> cvpcb).  I removed it and I cannot see any difference in the Eeschema
>>> toolbars.  If no one can justify why this code was added to the Eeschema
>>> toolbars, I'm going to remove it for the sake of consistency with the
>>> other app toolbars.
> 
> It could be a legacy code which has no effect currently (since a long time).
> (As far I remember, it had effect only on wxWidgets-GTK1, a relic ...)
> 
> 

Thanks JP.  I'll remove them from the code since they do not seem to
make any difference.



References