← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix segfault on quit

 

Actually this might also fix the other one too, don't know. But it won't
hurt to have both, so you might as well commit them for now. I'll finish
investigating the other one later tonight or tomorrow.
On Jun 22, 2015 19:43, "Chris Pavlina" <pavlina.chris@xxxxxxxxx> wrote:

> Addition. I still haven't tracked down the root cause of the other one,
> but this is unrelated.
> On Jun 22, 2015 19:41, "Wayne Stambaugh" <stambaughw@xxxxxxxxx> wrote:
>
>> Is this in addition to or instead of your previous patch that removed
>> destroy() from ~PGM_BASE()?
>>
>> On 6/22/2015 7:04 PM, Chris Pavlina wrote:
>> > Under certain (but not all) conditions, kicad applications segfault on
>> > quit. This has been reported:
>> >
>> > https://bugs.launchpad.net/kicad/+bug/1431028
>> > https://bugs.launchpad.net/kicad/+bug/1467221
>> >
>> > It appears to be the case that Pgm().OnPgmExit() was called in the wrong
>> > place. This patch moves it from APP_SINGLE_TOP::OnRun() to
>> > APP_SINGLE_TOP::OnExit(), which appears to correct the issue.
>> >
>> > --
>> > Chris
>> >
>> >
>> >
>> > _______________________________________________
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>

References