kicad-developers team mailing list archive

[Marco Hess <marco.hess@xxxxxxxxxxxxxx>]

Thanks Wayne.

On this item, I noted that in dialog_plot_base.cpp the checkbox for 
using these extensions are referred to as 'Protel'. Should we change 
that to 'Altium' to stay with the times?

Marco

On 25-Jun-15 03:30, Wayne Stambaugh wrote:
> Your patch was committed in the product branch r5818.  Thank you for
> your contribution to KiCad.
>
> Cheers,
>
> Wayne
>
> On 6/21/2015 1:25 AM, Marco Hess wrote:
> > The attached patch is a minor fix to the Protel gerber file name
> > extensions to assign
> > a more specific extension to internal Cu layers as well as the Edge_Cuts
> > layer
> > as described here on the Altium site:
> >
> > http://techdocs.altium.com/display/ADRR/WorkspaceManager_Dlg-GerberSetup_Form((Gerber+Setup))_AD
> >
> >
> > Regards,
> >
> > Marco
> >
> > diff --git a/pcbnew/pcbplot.cpp b/pcbnew/pcbplot.cpp
> > index 7d5527e..4b8f89e 100644
> > --- a/pcbnew/pcbplot.cpp
> > +++ b/pcbnew/pcbplot.cpp
> > @@ -55,7 +55,7 @@ const wxString GetGerberExtension( LAYER_NUM aLayer )
> >               return wxT( "gbl" );
> >           else
> >           {
> > -            return wxT( "gbr" );
> > +            return wxString::Format( wxT( "g%d" ), aLayer+1 );
> >           }
> >       }
> >       else
> > @@ -74,11 +74,12 @@ const wxString GetGerberExtension( LAYER_NUM aLayer )
> >           case B_Mask:        return wxT( "gbs" );
> >           case F_Mask:        return wxT( "gts" );
> >
> > +        case Edge_Cuts:     return wxT( "gm1" );
> > +
> >           case Dwgs_User:
> >           case Cmts_User:
> >           case Eco1_User:
> >           case Eco2_User:
> > -        case Edge_Cuts:
> >           default:            return wxT( "gbr" );
> >           }
> >       }
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

--
Marco Hess
Through IP Pty. Ltd. - AUSTRALIA
www.through-ip.com  | marco.hess@xxxxxxxxxxxxxx
p: +61 407 78 55 66 | f: +61 8 8121 6191