kicad-developers team mailing list archive

[Simon Richter <Simon.Richter@xxxxxxxxxx>]

Hi,

this fixes a bug in the pin table, where a "break;" between two case
statements is indeed incorrect, despite what Coverity claims.

   Simon



From 2e0b3d621520478ea0baae9d19d0ef8d7627652a Mon Sep 17 00:00:00 2001
From: Simon Richter <Simon.Richter@xxxxxxxxxx>
Date: Thu, 25 Jun 2015 00:22:11 +0200
Subject: [PATCH] Coverity warns here, but falling through here is actually
 correct.

This handles the case where the second member for a group is found.
In this case, the first element is moved into the group, and the
second member processed the same as any further members.
---
 eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eeschema/dialogs/dialog_lib_edit_pin_table.cpp b/eeschema/dialogs/dialog_lib_edit_pin_table.cpp
index 5826919..dc39b53 100644
--- a/eeschema/dialogs/dialog_lib_edit_pin_table.cpp
+++ b/eeschema/dialogs/dialog_lib_edit_pin_table.cpp
@@ -526,7 +526,7 @@ void DIALOG_LIB_EDIT_PIN_TABLE::DataViewModel::Group::Add( Pin* aPin )
 
     case 1:
         m_Members.front()->SetGroup( this );
-        break;
+        // fall through
 
     default:
         aPin->SetGroup( this );
-- 
2.1.4

Attachment: signature.asc
Description: OpenPGP digital signature