← Back to team overview

kicad-developers team mailing list archive

Re: A question about the crosshair behaivour

 

On 7/12/2015 2:08 PM, Andrew Zonenberg wrote:
> I'll write up a patch to clean up the cursors (GAL only, not going to
> worry about legacy since that's so full of artifacts anyway) and push
> it to my advanced-feature-bugfixes branch in a few.

It would be nice if you could fix both canvases.  There are not many
artifacts when just drawing the crosshairs.  Artifacts in the legacy
cursor are primarily caused by editing, placing, and moving items.

> 
> On 12/07/15 10:42, Bernhard Stegmaier wrote:
>> For my taste it should be cleared. If you leave some active area
>> IMHO it doesn’t make sense to keep any old/inactive traces of a
>> tool/cursor… In fact, I find it hard to identify the real active
>> mouse position when multiple (old, but inactive) cursors are
>> visible on the screen.
> 
>> When writing this mail I have a text cursor when moving around in
>> the text window. The text cursor also doesn’t stay visible at the
>> edge of the text window when leaving the text window...
> 
> 
>> Regards, Bernhard
> 
>>> On 12 Jul 2015, at 18:46, Nick Østergaard <oe.nick@xxxxxxxxx>
>>> wrote:
>>>
>>> Hello All
>>>
>>> When testing Andrew's patch from yesterday and the fact we
>>> finally got the crosshair ported to GAL, I have noticed that when
>>> the mouse pointer cursor exits the canvas the crosshair will
>>> freeze at the edge of the canvas.  I have not thought more deeply
>>> about this before, because it is usual to the legacy canvas to
>>> have drawing artifacts.
>>>
>>> But what I really is asking now is; should it be like that or
>>> should it clear from the canvas?
>>>
>>> Please note this is when any tool except the pointer tool is
>>> active. The same behaivour is seen in the legacy canvas except it
>>> does not hide the cross hair in the select tool.
>>>
>>> Andrew told me to mention that he offered to fix it if people
>>> think that a fix is required. He estimate it'd take him 5 mins to
>>> make a patch to hide the cursor in the leave handler. It will be
>>> like a 4-line patch to common/view/wx_view_controls.cpp in
>>> onEnter and onLeave.
>>>
>>> He is willing to patch it if the consensus is that a fix is
>>> required.
>>>
>>> About the inconsistency about the select tool having the cross
>>> hair or not, he said he likes to have it becauese he uses to
>>> check alignment of stuff. This should of course lead the mind to
>>> think of https://xkcd.com/1172/.
>>>
>>> Regards Nick Østergaard
>>>
>>> _______________________________________________ Mailing list:
>>> https://launchpad.net/~kicad-developers Post to     :
>>> kicad-developers@xxxxxxxxxxxxxxxxxxx Unsubscribe :
>>> https://launchpad.net/~kicad-developers More help   :
>>> https://help.launchpad.net/ListHelp
> 
> 
>> _______________________________________________ Mailing list:
>> https://launchpad.net/~kicad-developers Post to     :
>> kicad-developers@xxxxxxxxxxxxxxxxxxx Unsubscribe :
>> https://launchpad.net/~kicad-developers More help   :
>> https://help.launchpad.net/ListHelp
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 



Follow ups

References