kicad-developers team mailing list archive

[Marco Hess <marco.hess@xxxxxxxxxxxxxx>]

From what I have been able to investigate on this is that the polyshape 
rendering is not implemented in the legacy canvas.

With respect to the not being able to move, I think that this has 
something to do with the hit detection that also does not implement 
polyshapes.

When used in the module editor, when you look at the module file where 
you imported the DXF, you will notice that the fp_poly shape in the file 
does not have any xy points. Upon reloading the module file, the module 
editor crashes because it probably expects xy points in the shape.

On the moving of the shape, the current PCB file gr_poly definition 
would require ALL xy points in the shape to be transformed to do a move. 
I think it ideally should be another shape definition that has an XY 
origin (and possibly an angle) and then the rest of the shape positions 
are relative to that XY origin. In that way the shape can be moved 
without having to recalculate the relative positions of the shape 
corners (and possibly distorting them after a few moves). I feel that 
might be a safer way of dealing with a complex shape.

Marco



On 02-Aug-15 05:56, easyw wrote:
> Hi Maciej,
>
> I tried the version 6023 in win8 64 with the Marco's patch...
> in pcbnew the import now is done also in OpenGL, but the shape is not 
> shown in legacy canvas (I'm importing with fill polygons selected).
> In module editor if I import the shape I get a crash
>
> @Marco
> in pcbnew when the shape is imported and shown, after selecting a 
> block, it is not possible to move it
> I cannot test in modedit because I get a crash after switching to OpenGL
>
> thanks
> Maurice
>
>
> On 30/07/2015 14.25, Maciej Sumiński wrote:
> > Hi Marco,
> >
> > Thank you for reporting the issue. It should be fixed in revision 6023.
> >
> > Regards,
> > Orson
> >
> > On 07/30/2015 02:40 AM, Marco Hess wrote:
> > > Hi Maciej,
> > >
> > > I am testing this on Windows version: (2015-07-11 BZR 5925, Git
> > > c291b88)-product release build
> > >
> > > In all cases I have the DXF import dialog (both PCB new and module 
> > > editor).
> > >
> > > It is just when the OpenGL canvas is active, clicking Ok in the dialog,
> > > there is no import happening. The 'Save' icon remains off/disabled and
> > > there is nothing added to the PCB file.
> > >
> > > When the legacy canvas is active, the import succeeds. The 'Save' icon
> > > comes active and you can see the imported lines in the PCB file. You 
> > > can
> > > then switch to OpenGL and the shape is shown.
> > >
> > > Attached the antenna DXF that I am trying this with.
> > >
> > > Marco
> > >
> > > On 29-Jul-15 22:25, Maciej Sumiński wrote:
> > > > On 07/29/2015 12:25 PM, Marco Hess wrote:
> > > > [snip]
> > > > > But the DXF import only working in legacy mode and not in the other
> > > > > modes is a
> > > > > definitely a bug I think.
> > > > >
> > > > > Marco
> > > > Hi Marco,
> > > >
> > > > I have just tried importing the mentioned file and it worked here. 
> > > > Could
> > > > you give some more details about the problem? What happens when you
> > > > choose File->Import->DXF file? Do you see the import DXF dialog? Does
> > > > the imported DXF shape appear at all?
> > > >
> > > > Regards,
> > > > Orson
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

--
Marco Hess
Through IP Pty. Ltd. - AUSTRALIA
www.through-ip.com  | marco.hess@xxxxxxxxxxxxxx
p: +61 407 78 55 66 | f: +61 8 8121 6191