kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #19730
Re: [PATCH] Cleaner entry of arc angles
Hi Wayne et al,
Coming back to this after no reply in four months to the patch I posted to
the wxFormBuilder tracker (see my other email to the list about the future
of wxFB).
On 14 May 2015 at 01:03, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>
> I was looking at this patch and I like the idea of entering arc angles
> in degrees instead of deci-degrees. I'm sure most users will appreciate
> it. However, the wxSpinCtrl hack needs to be replaced by using a
> wxSpinCtrl when creating the dialog with wxFormBuilder. wxFormBuilder
> v3.5 supports wxSpinCtrl.
Sorry, I didn't explain the issue very clearly.
The wxSpinCtrl widget only handles integer inputs. This would mean that
either the user still inputs deci-degrees, or the angular resolution is
limited to whole degrees.
wxWidgets > 2.9 has an extra widget, wxSpinCtrlDouble, which returns a
double value. This is ideal for inputting degrees.
However, wxFormBuilder doesn't know that wxSpinCtrlDouble exists, and
therefore we cannot place it directly in a dialog through wxFB.
My patch (which doesn't apply cleanly anymore BTW) proposes using a
wxSpinCtrl from within wxFB as a placeholder. The actual dialog class,
which inherits from the base class created by wxFB, replaces this with a
wxSpinCtrlDouble.
> This is kind of polishing that I would like
> to see make it into the stable release.
If you're OK with my proposed method, then I'll go through and change all
existing dialogs which input angles to match, and post a patch accordingly.
Blair
Follow ups
References