kicad-developers team mailing list archive

[Garth Corral <gcorral@xxxxxxxxx>]

> On Nov 2, 2015, at 12:20 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> 
> 
> 
> On 11/2/2015 3:00 PM, Garth Corral wrote:
>> 
>>> On Nov 2, 2015, at 10:25 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>> 
>>> On 11/1/2015 9:42 AM, Bernhard Stegmaier wrote:
>>>> If this capability should be added now, it should be done consistent for all platforms.
>>>> We had this discussion for OS X already way back, but back then nobody seemed to be interested in adding also for Windows/Linux…
>>>> 
>>>> Garth made some changes where you even could switch between mouse wheel X/Y panning and normal behaviour via preferences menu.
>>> 
>>> If I remember correctly, Garth's changes broke the existing behavior
>>> which made it a non-starter.  If this fix didn't break the existing
>>> behavior then I wouldn't have a problem accepting it but not until after
>>> the stable release.  It's getting too late for changes that could
>>> potentially introduce new bugs.  Our mouse event handling code is a mess
>>> and very fragile so adding more changes to it is just inviting problems.
>>> 
>> To be clear, it did not break the behavior.  It was a conscious decision to change the currently broken behavior.  I knew it would not be received well, but whatever.
> 
> Refresh my memory.  What is broken about the current behavior?  I
> thought this was adding new behavior to handle track pad devices which
> should not have impacted the mouse scroll wheel panning.  Are you saying
> that this could not be implemented without changing the current panning
> behavior?
> 
I changed the behavior with regard to the panning direction and modifier keys to be more in line with UI convention and also to fix the incorrect left/right panning with the mousewheel.  When you’re rolling a mousewheel up and down you might not notice or care which left/right direction that translates to when modified, but when you’re actually scrolling in four directions on a trackpad it becomes obvious.  So it’s unlikely that most mouse users would notice that there is any issue, but trackpad users will.

The point is sort of moot now anyway.  I’m not currently in a position to commit that code.  I think that Bernhard had some parallel changes in his tree that accomplish much of the same things.  Perhaps that can go in at some point.  I still occasionally see posts on forums & lists complaining of OS X usability issues around trackpad use, it would be good to sort that out.  I’m trying to work with my employer so that I’ll be able to contribute again in the future but I’m pretty much out at this point.

Garth

Attachment: smime.p7s
Description: S/MIME cryptographic signature