← Back to team overview

kicad-developers team mailing list archive

Re: github plugin bug (probably bad thing to be in the stable)

 

Becareful if testing with a web browser, ssl pinning will probably
make it look like the "http" works but if you check the downloads path
it will be "https".

The proper way to test is curl which will show it fails.
curl -v -O -L http://codeload.github.com/liftoff-sr/pretty_footprints/zip/master

On Mon, Nov 30, 2015 at 2:05 AM, Mark Roszko <mark.roszko@xxxxxxxxx> wrote:
> https://github.com/KiCad/kicad-source-mirror/blob/master/pcbnew/github/github_plugin.cpp#L463
>
> The github plugin translates github urls to the codeload subdomain.
> The problem is very recently "http" support was disabled on the
> codeload subdomain and so any github urls being rewritten to codeload
> will now fail if it is http.
>
> i.e.
> http://codeload.github.com/liftoff-sr/pretty_footprints/zip/master will fail
> https://codeload.github.com/liftoff-sr/pretty_footprints/zip/master
>
> Will work.
>
> If one uses the original http release url like
> http://github.com/KiCad/Varistors.pretty/archive/4.0.0.zip
>
> it will work via the redirects on their base domain
>
>
>
> People have been complaining alot on IRC about broken github
> libraries, this explains why.
>
> --
> Mark



-- 
Mark


References