← Back to team overview

kicad-developers team mailing list archive

Re: github plugin bug (probably bad thing to be in the stable)

 

How is http getting used instead of https?  The default KIGITHUB url is
https://github.com/KiCad.  Is this a user configuration issue or is the
footprint wizard using http instead of https?

On 11/30/2015 2:05 AM, Mark Roszko wrote:
> https://github.com/KiCad/kicad-source-mirror/blob/master/pcbnew/github/github_plugin.cpp#L463
> 
> The github plugin translates github urls to the codeload subdomain.
> The problem is very recently "http" support was disabled on the
> codeload subdomain and so any github urls being rewritten to codeload
> will now fail if it is http.
> 
> i.e.
> http://codeload.github.com/liftoff-sr/pretty_footprints/zip/master will fail
> https://codeload.github.com/liftoff-sr/pretty_footprints/zip/master
> 
> Will work.
> 
> If one uses the original http release url like
> http://github.com/KiCad/Varistors.pretty/archive/4.0.0.zip
> 
> it will work via the redirects on their base domain
> 
> 
> 
> People have been complaining alot on IRC about broken github
> libraries, this explains why.
> 


References