← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 1/4] Use CMake high-level facility for visibility

 

I can but I need to get the 4.0.0 build out first.

If someone else can do it sooner than end of this week/weekend, please do :)

On Wed, Dec 2, 2015 at 8:30 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

> Would one of our OSX devs please confirm this doesn't break anything on
> OSX builds before I commit it.
>
> Thanks,
>
> Wayne
>
> On 12/1/2015 2:14 AM, Simon Richter wrote:
> >
> > CMake 3.0 defines two new variables,
> >
> >  * CMAKE_CXX_VISIBILITY_PRESET and
> >  * CMAKE_VISIBILITY_INLINES_HIDDEN
> >
> > to control whether symbols not explicitly tagged for export are
> implicitly
> > exported. Because only version 3.3 and following also applies that to
> > static libraries when in 3.3 mode, compatibility code is added as well.
> >
> > When the minimum required version is bumped to 3.3, this code becomes
> > obsolete and a warning is displayed that the compatibility code should be
> > removed as well.
> > ---
> >  CMakeLists.txt                          | 32
> ++++++++++++++++++++++++--------
> >  CMakeModules/PerformFeatureChecks.cmake |  2 --
> >  2 files changed, 24 insertions(+), 10 deletions(-)
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References