kicad-developers team mailing list archive

[Kristian Nielsen <knielsen@xxxxxxxxxxxxxxx>]

Mark Roszko <mark.roszko@xxxxxxxxx> writes:

> I have written a replacement implementation that drops avhttp in favor
> of libcurl.

Works for me on Debian stable.

And as a bonus, broken network connection now causes a timeout rather than
an infinite hang:

  Errors were encountered loading footprints
  IO_ERROR: https://codeload.github.com/KiCad/Relays_ThroughHole.pretty/zip/master
  Cannot get/download Zip archive: 'https://github.com/KiCad/Relays_ThroughHole.pretty'
  for library path: 'IO_ERROR: CURL Request Failed: Timeout was reached

You seem to have trailing whitespace lines in your patch, you might want to
remove those.

And you left a comment about avhttp on the function
GITHUB_GETLIBLIST::remoteGetJSON() when you moved/renamed it, probably that
comment should be deleted now?

Thanks,

 - Kristian.