kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

The following error messages in pcbnew are poorly written:

- The duplicated zone is on the same layer as the initial zone, which 
  has no sense. Please, choose another layer for the new zone.

  + for obvious reasons, broken English

- The outline of the duplicated zone fails DRC check!

  + "DRC check" is redundant
  + This is erroneously displayed as an error - it's a warning, not an 
    error. The operation actually proceeds in spite of the "error".
  + "The outline of the duplicated zone" is slightly confusing and 
    ambiguous
  + The exclamation point makes it read weirdly excited

This patch rewrites them:

- "The duplicated zone cannot be on the same layer as the original 
  zone."

- "Warning: The new zone fails DRC" (also changed this from DisplayError 
  to DisplayInfoMessage)

Apologies for the patch noise, but someone pointed this out to me on IRC
and I couldn't help myself :)

--
Chris

commit 3f53a390878be61e76383713f8f1e5371789ad62
Author: Chris Pavlina <cpavlin1@xxxxxxxxxxxxxx>
Date:   Mon Dec 7 18:10:29 2015 -0500

    Fix a couple duplicated zone messages

diff --git a/pcbnew/zones_by_polygon.cpp b/pcbnew/zones_by_polygon.cpp
index c6e1056..4d5663b 100644
--- a/pcbnew/zones_by_polygon.cpp
+++ b/pcbnew/zones_by_polygon.cpp
@@ -128,8 +128,7 @@ void PCB_EDIT_FRAME::duplicateZone( wxDC* aDC, ZONE_CONTAINER* aZone )
     if( success && ( aZone->GetLayer() == zoneSettings.m_CurrentZone_Layer ) )
     {
         DisplayError( this,
-            _( "The duplicated zone is on the same layer as the initial zone, which has no sense.\n"
-               "Please, choose an other layer for the new zone") );
+            _( "The duplicated zone cannot be on the same layer as the original zone." ) );
         success = false;
     }
 
@@ -158,8 +157,7 @@ void PCB_EDIT_FRAME::duplicateZone( wxDC* aDC, ZONE_CONTAINER* aZone )
         if( GetBoard()->GetAreaIndex( newZone ) >= 0
            && GetBoard()->Test_Drc_Areas_Outlines_To_Areas_Outlines( newZone, true ) )
         {
-            DisplayError( this,
-                _( "The outline of the duplicated zone fails DRC check!" ) );
+            DisplayInfoMessage( this, _( "Warning: The new zone fails DRC" ) );
         }
 
         UpdateCopyOfZonesList( s_PickedList, s_AuxiliaryList, GetBoard() );