← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Eeschema options step 2: template fields

 

Patch committed in r6410.  Nice work.  I like the
TransferData{To,From}Window changes.  It makes for cleaner code.  At
some point in the future, I'm going to make this a policy that all
dialogs use this method for data transfer unless there is a good reason
not to.

Thanks,

Wayne

On 12/27/2015 4:06 PM, Chris Pavlina wrote:
> Urgh, today seems to be a great day for making mistakes. Take #3, I 
> found a bug. Sorry for the noise.
> 
> On Sun, Dec 27, 2015 at 03:02:05PM -0500, Chris Pavlina wrote:
>> Sorry, quick update - fix a couple (non-critical) signed/unsigned 
>> mismatches and remove an unused member. This is a new version of the 
>> patch in the previous mail, not an incremental patch.
>>
>> On Sun, Dec 27, 2015 at 01:25:24PM -0500, Chris Pavlina wrote:
>>> Hi,
>>>
>>> This patch reimplements the Template/Default Fields page in the Eeschema 
>>> options using wxGrid, making the table directly user-editable and 
>>> removing the somewhat dodgy code for the separate edit panel. This fixes 
>>> <https://bugs.launchpad.net/kicad/+bug/1527309> as well as, IMO, making 
>>> this dialog much more user-friendly. The field options have also been 
>>> upgraded to use the newer TransferData{To,From}Window methods.
>>>
>>> Step 3 will be to pull the hotkey manager into this dialog.
>>>
>>> --
>>> Chris
>>>
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp


References