kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #22622
Re: [PATCH] Separate ElectricPinType and TypeSheetLabel
Please do not commit this patch until after I completed committing all
41 of my eeschema refactor patches. This one will most likely cause a
conflict which I would like to avoid.
Thanks,
Wayne
On 1/14/2016 11:23 AM, Simon Richter wrote:
>
> These enums are silently treated as equivalent in the ERC, because the
> values are casted to integers. This works for the most part, because the
> values are similar, but this is in no way enforced, and there is a small
> inconsistency (NET_UNSPECIFIED vs PIN_PASSIVE).
>
> This turns the storage into a discriminated union, and provides an accessor
> method that checks that a meaningful value can be returned and returns an
> ElectricPinType in any case.
> ---
> eeschema/class_netlist_object.cpp | 36 ++++++++++++++++++++++++++++++++++--
> eeschema/class_netlist_object.h | 3 +++
> eeschema/erc.cpp | 8 ++++----
> 3 files changed, 41 insertions(+), 6 deletions(-)
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References