kicad-developers team mailing list archive

[José Ignacio <jose.cyborg@xxxxxxxxx>]

That patch doesn't seem to add msvc specific code, in fact it seems to
just _remove_ MINGW specific code.

-#if defined(__MINGW32__)
+#if defined(_WIN32)


On Sat, Jan 16, 2016 at 1:34 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> Please do not commit this patch.  The current policy is no MSVC specific
> code in KiCad and I'm not interested in changing that policy any time soon.
>
> Thanks,
>
> Wayne
>
> On 1/15/2016 11:41 PM, Simon Richter wrote:
>>
>> Windows-style dllimport/dllexport should be used whenever targetting
>> Windows directly, not just for MINGW.
>>
>> ---
>>  include/import_export.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp