kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #23296
Re: 3D refactor
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Mon, 22 Feb 2016 11:00:34 -0500
-
In-reply-to:
<CAHBNN+NGnTF9bXUcVPzhH185s=irf4UjYhBZ8ECUP5xCy8rZWg@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
Cirilo,
I have one last change request that I missed in my previous review.
Please change your debugging output method. Windows apps have no
concept of stdout even when run from the command line. wxLogTrace is
the preferred method for debugging output. It solves two problems. The
debugging strings are redirected to the correct output on all supported
platforms and the debugging output is turned off by default. Turning on
the debugging output is as simple as:
export WXTRACE="SOME_DEBUGGING_OUTPUT_TO_ENABLE"
The is handy so I don't have to sift through everyone's debugging output
to find what I'm looking for. You just need to pick a unique string not
used by any other kicad wxLogTrace calls to enable tracing of your
debugging output.
I'm still not thrilled about using a list of paths to search for 3D
model files. This is broken in the same way the the component library
search path ordering is broken in Eeschema. Since it's no worse than
what we have now and fixes some of the current 3D model file loading
issues, I'm willing to commit it but in the long run I think we really
need to think about this more carefully and come up with a better way to
resolve 3D model file names.
Cheers,
Wayne
On 2/21/2016 7:28 PM, Cirilo Bernardo wrote:
> Hi Folks,
>
> Any thoughts on merging the 3d_initial_merge branch? Between
> mainly Mario and myself and a few reports by others (nickoe,
> reportingsjr) we have sorted out quite a few bugs and other
> deficiencies but I think the only way to get more testing from users
> is to merge the code. I believe that the new parsers all offer much
> better specifications compliance compared to the old parsers and
> the code is more robust. As an example, there is this post by a
> user:
>
> https://forum.kicad.info/t/trouble-with-3d-models-vrml/2320/7
>
> The user's models, D_Pak.wrl (VRML1) and D_Pakx.wrl (VRML2)
> load and display correctly in the file preview which uses the new
> parsers. In the legacy parsers, D_Pak.wrl causes a segfault and
> D_Pakx.wrl does not display correctly. Note: the 3d_initial_merge
> branch still uses the legacy 3DViewer so the 3DViewer will segfault
> on the D_Pak.wrl model, but for me this only serves as a reminder
> of some of the improvements gained with the new 3D plugin system.
>
> - Cirilo
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References