← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 0/5] Enum refactoring and shiny icons

 

Le 26/02/2016 22:07, Simon Richter a écrit :
> Hi,
> 
> this refactors two enum types, ELECTRICAL_PINTYPE and DrawPinShape (which
> becomes GRAPHIC_PINSHAPE):
> 
> 1. Move enum to separate header file, out of lib_pin.h.
> 2. Move UI text and bitmap lookup out of LIB_PIN (end goal: no UI code in
>    data structures)
> 3. Create separate widget class for use in dialogs, that is completely
>    self-initializing to maximize reusability
> 
> Then, the TypeSheetLabel enum type is used explicitly where possible, for
> better typesafety (this is what is left of the ERC changes posted earlier).
> 
> Finally, the "pin type" column in the pin table gets icons to hopefully
> enhandle readability. This requires the text/bitmap lookup changes from
> earlier, that's why it's in this patch set.
> 
>    Simon


Patches committed in rev 6598.
Thanks.


-- 
Jean-Pierre CHARRAS


References