kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Mikael,

I just tested your patches and they do unify the block mirror behavior
but the rotate hot key (R) does not rotate a block in component library
editor.  I would prefer that you fix that before I commit your patches.
 Also, you have some copy policy violations (trailing white space, curly
bracket placement, and missing spaces between text and braces) in your
patch.  Since it's your first patch, I will cut you some slack but in
the future please submit patches that to adhere to the coding policy[1].

Cheers,

Wayne

[1]:
http://ci.kicad-pcb.org/job/kicad-doxygen/ws/Documentation/doxygen/html/md_Documentation_development_coding-style-policy.html

On 2/24/2016 12:43 PM, Mikael Arguedas wrote:
> Hi guys,
> 
> Here are two patches:
> unifyCopyBlock.patch: makes the CopyBlock function in library editor
> match the behaviour of the one in schematic editor
> addMirrorHotkeys.patch:
> - adds the HkMirrorX and HkMirrorY hotkeys to library editor
> - allor the HkRotate hotkey to rotate blocks and not only items
> 
> Regards,
> Mikael
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>