← Back to team overview

kicad-developers team mailing list archive

Re: Linux new line bug fix.

 

Okay, no, 6659 does actually at least one bug.

Steps:
1. Place component
2. Press E over the value field to edit it

--- first bug: "Power component value text cannot be modified!" is displayed,
even though this is not a power component.

3. Press OK.

--- second bug, maybe?

I have one report from a friend that the modified value does not always get
saved at this point. I was not able to reproduce, but apparently it's
intermittent.


On Sat, Apr 02, 2016 at 11:49:58AM -0400, Wayne Stambaugh wrote:
> Thanks for the testing.  I wonder if there are any other single line
> text edit controls where this same behavior can be an issue.  If you
> happen to find any, please let me know and I will fix them.
> 
> On 4/2/2016 9:41 AM, Chris Pavlina wrote:
> > Tested with a few hellish combinations of characters and everything I could
> > think of managed not to break it. Also, three thumbs up from me about not
> > liking programs silently changing what you've typed.
> > 
> > On Sat, Apr 02, 2016 at 08:37:51AM -0400, Wayne Stambaugh wrote:
> >> I just committed the fix for this
> >> https://bugs.launchpad.net/kicad/+bug/1529358 bug.  It was more involved
> >> that I thought it would be (isn't it always?) so I would appreciate some
> >> help testing this to make sure I didn't break anything particularly on
> >> OSX.  Mainly I need to make sure that I didn't accidentally limit any
> >> valid field characters or break the component value (renaming) field
> >> code.  As of now, you cannot use \r, \n, or \t in any field and
> >> reference designators cannot contain spaces.  I also changed the leading
> >> and trailing white space behavior.  In the past, leading and trailing
> >> white spaces would silently be removed.  I changed that so you now get a
> >> warning so you can fix it.  I personally don't like programs silently
> >> changing information I typed.  I would rather be warned that what I
> >> typed is invalid.  I can change this back if users find it too
> >> objectionable.
> >>
> >> Thanks,
> >>
> >> Wayne
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


Follow ups

References