kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #23954
Re: a few minor issues in code
-
To:
Cirilo Bernardo <cirilo.bernardo@xxxxxxxxx>, KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Mário Luzeiro <mrluzeiro@xxxxx>
-
Date:
Mon, 4 Apr 2016 22:22:30 +0000
-
Accept-language:
en-GB, en-US
-
Authentication-results:
gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=ua.pt;
-
In-reply-to:
<CAHBNN+PH5yozh_-N=ozow=-Ld2sULnMu84pNnOoXQa0CohBZHA@mail.gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:23
-
Thread-index:
AQHRjrf8zTpDSM/RwUOJLWzhH/4tAp96YwRA
-
Thread-topic:
[Kicad-developers] a few minor issues in code
Hi Cirilo,
Searching in github for the ObjectCoordsTo3DUnits funtion, it is not used :)
... dead code,
Cheers
Mario
________________________________________
From: Kicad-developers [kicad-developers-bounces+mrluzeiro=ua.pt@xxxxxxxxxxxxxxxxxxx] on behalf of Cirilo Bernardo [cirilo.bernardo@xxxxxxxxx]
Sent: 04 April 2016 21:56
To: KiCad Developers
Subject: [Kicad-developers] a few minor issues in code
Hi folks,
While working on adding a dummy board with footprint to the 3D file selector preview,
I ran across a few issues:
1. in 3d-viewer/3d_aux.cpp L59 - L84 there seems to be a cut/paste problem.
In the "if( m_MatRotation.y )" and "if( m_MatRotation.z )" blocks the rotation
used is m_MatRotation.x. I have no idea how this affects the operation of the
code thogh.
2. class_eda_rect.h is missing "#include <wx/gdicmn.h>". If I include that header
without previously including gdicmn.h I get a compile error.
- Cirilo
References
