← Back to team overview

kicad-developers team mailing list archive

Re: a few minor issues in code

 

Le 04/04/2016 22:56, Cirilo Bernardo a écrit :
> Hi folks,
> 
>  While working on adding a dummy board with footprint to the 3D file
> selector preview,
> I ran across a few issues:
> 
> 1. in 3d-viewer/3d_aux.cpp L59 - L84 there seems to be a cut/paste problem.
> In the "if( m_MatRotation.y )" and "if( m_MatRotation.z )" blocks the
> rotation
> used is m_MatRotation.x.  I have no idea how this affects the operation of
> the
> code thogh.

This is a bug (cut/paste problem).
As Mario said, it was not noticed because it is not used

> 
> 2. class_eda_rect.h is missing "#include <wx/gdicmn.h>".  If I include that
> header
> without previously including gdicmn.h I get a compile error.
> 
> - Cirilo

Yes, it is missing "#include <wx/gdicmn.h>".
It was not noticed because most of time class_eda_rect.h is used through the base_struct.h file

-- 
Jean-Pierre CHARRAS


References