kicad-developers team mailing list archive

[Simon Richter <Simon.Richter@xxxxxxxxxx>]

Hi,

first Jenkins builds after the merge went through, we have a few new
warnings. The msys build is rather silent[1]:

ogl_legacy_utils.cpp:209
 variable 'end' set but not used [-Wunused-but-set-variable]

The MSVC build has a few more new warnings[2], sorted by category here:

vrml.cpp:185
 'e': unreferenced local variable

wrlfacet.cpp:121
 'initializing': conversion from 'double' to 'float', possible loss of data

wrlfacet.cpp:771 [64 bit build only]
 'argument': conversion from 'size_t' to 'int', possible loss of data

clayer_triangles.h:105 [64 bit build only]
 'return': conversion from 'size_t' to 'unsigned int', possible loss of data

clayer_triangles.h:111 [64 bit build only]
 'return': conversion from 'size_t' to 'unsigned int', possible loss of data

There are 90 new "truncation from double to float" warnings, I believe
these are mostly uninteresting. The difference to "conversion" warnings
is that "truncation" happens to compile-time constants.

On the 32 bit build, there are 30 instances of objects not allocated
with the required alignment:

3d_frame.cpp:204
 'EDA_3D_CANVAS': object allocated on the heap may not be aligned 16

c3d_model_viewer.cpp
 'C_OGL_3DMODEL': object allocated on the heap may not be aligned 16

c_ogl_3dmodel.cpp:54
 'CBBOX': object allocated on the heap may not be aligned 16

vrml_v1_modelparser.cpp:91
 'S3D_MESH': object allocated on the heap may not be aligned 16

vrml_v1_modelparser.cpp:127
 'S3D_MESH': object allocated on the heap may not be aligned 16

vrml_v2_modelparser.cpp:165
 'S3D_MESH': object allocated on the heap may not be aligned 16

vrml_v2_modelparser.cpp:203
 'S3D_MESH': object allocated on the heap may not be aligned 16

vrml_v2_modelparser.cpp:241
 'S3D_MESH': object allocated on the heap may not be aligned 16

vrml_v2_modelparser.cpp:344
 'S3D_MESH': object allocated on the heap may not be aligned 16

vrml_v2_modelparser.cpp:485
 'S3D_MESH': object allocated on the heap may not be aligned 16

vrml_v2_modelparser.cpp:806
 'S3D_MESH': object allocated on the heap may not be aligned 16

vrml_v2_modelparser.cpp:852
 'S3D_MESH': object allocated on the heap may not be aligned 16

x3dmodelparser.cpp:97
 'S3D_MESH': object allocated on the heap may not be aligned 16

class_module.cpp:79
 'S3D_MASTER': object allocated on the heap may not be aligned 16

class_module.cpp:149
 'S3D_MASTER': object allocated on the heap may not be aligned 16

class_module.cpp:156
 'S3D_MASTER': object allocated on the heap may not be aligned 16

class_module.cpp:284
 'S3D_MASTER': object allocated on the heap may not be aligned 16

class_module.cpp:299
 'S3D_MASTER': object allocated on the heap may not be aligned 16

dialog_edit_module_for_BoardEditor.cpp:277
 'S3D_MASTER': object allocated on the heap may not be aligned 16

dialog_edit_module_for_BoardEditor.cpp:542
 'S3D_MASTER': object allocated on the heap may not be aligned 16

dialog_edit_module_for_BoardEditor.cpp:602
 'S3D_MASTER': object allocated on the heap may not be aligned 16

dialog_edit_module_for_BoardEditor.cpp:748
 'S3D_MASTER': object allocated on the heap may not be aligned 16

dialog_edit_module_for_BoardEditor.cpp:771
 'S3D_MASTER': object allocated on the heap may not be aligned 16

dialog_edit_module_for_Modedit.cpp:130
 'S3D_MASTER': object allocated on the heap may not be aligned 16

dialog_edit_module_for_Modedit.cpp:409
 'S3D_MASTER': object allocated on the heap may not be aligned 16

dialog_edit_module_for_Modedit.cpp:469
 'S3D_MASTER': object allocated on the heap may not be aligned 16

dialog_edit_module_for_Modedit.cpp:581
 'S3D_MASTER': object allocated on the heap may not be aligned 16

dialog_edit_module_for_Modedit.cpp:604
 'S3D_MASTER': object allocated on the heap may not be aligned 16

legacy_plugin.cpp:1886
 'S3D_MASTER': object allocated on the heap may not be aligned 16

pcb_parser.cpp:311
 'S3D_MASTER': object allocated on the heap may not be aligned 16
	
The rest appears to be smaller stuff:

ifsg_node.h:171
 'IFSG_NODE': multiple copy constructors specified

The compiler also complains that exception processing is turned off, but
we use math functions that may throw exceptions (Windows converts divide
by zero to an exception) -- I'm just going to turn on exception handling
on MSVC to get rid of the noise.
	
Finally, there are linker warnings about duplicate definitions for
cimage.obj and trackball.obj -- these appear to be linked twice, but as
they end up in a static library, the first definition shadows the
second, and no compiler error occurs.

   Simon	

[1]
http://ci.kicad-pcb.org/job/windows-kicad-msys2-nightlies/555/warnings24Result/new/

[2]
http://ci.kicad-pcb.org/job/windows-kicad-msvc-head/863/warnings35Result/new/

Attachment: signature.asc
Description: OpenPGP digital signature