kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Yup, I wasn't going to leave the function exactly as is. Hotkey should be
pulled from config. I also don't like the way it checks whether an origin has
been set.

On Wed, May 11, 2016 at 09:12:36AM +0200, jp charras wrote:
> Le 11/05/2016 à 00:25, Chris Pavlina a écrit :
> > Ooh, I like! I'll test and merge this tonight if nobody else complains. I have
> > no problem with showing a hint when no origin has been set.
> > 
> > Note for the future, use _() instead of wxT() to make a string that can be
> > translated - and a couple bits don't follow the defined coding style. I'll just
> > fix it myself this time though, NBD :)
> 
> About the hint, [space] is not always the right hotkey, because it is editable by the hotkey editor.
> 
> 
> > 
> > On Wed, May 11, 2016 at 12:16:51AM +0200, Martin d'Allens wrote:
> >> I think that the current ruler feature works great. Unfortunately
> >> people don't discover it easily.
> >> There are frequent questions on the user forum that we just answer by
> >> mentioning the space hotkey and how it works.
> >>
> >> Here is a patch that could solve this problem:
> >> https://github.com/KiCad/kicad-source-mirror/compare/master...Caerbannog:master.patch
> >> The patch needs improvements to show the current shortcut if "space"
> >> was changed.
> >>
> >> The idea is to show a hint about the space shortcut instead of the DX
> >> DY values until the key has been pressed.
> >> There is no disadvantage since the DX and DY values will be redundant
> >> with the X and Y until the key has been pressed.
> >>
> 
> 
> 
> -- 
> Jean-Pierre CHARRAS
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp