← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 07/12] Work around VC++ 2015 bug.

 

I'm not going to commit this one without approval, since we've already stated
we're not going to support MSVC.

On Fri, May 27, 2016 at 04:32:54PM +0200, Simon Richter wrote:
> 
> The combination of
>  - template resolution
>  - optimization
>  - structured exception handling
>  - chained operator=
> 
> appears to trigger a bug in the compiler.
> 
> As this code is nonsensical anyway (numeric_limits<>::min() returns the
> smallest positive value for floating point types, but the largest negative
> value for integral types), it should probably be rewritten.
> 
> This change just avoids the compiler bug, though.
> ---
>  include/math/box2.h | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 



Follow ups

References