← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Add zoom-to-selection tool

 

Pushed in 6904. Let me know if you have any issues with it.

I believe the centering problem mentioned in the original email to be fixed as
of 6903. I originally stated that it was an OSX issue, but I think rather it
was only noticed by Simon Wells who was testing on OSX, and just not very
noticeable here. I managed to reproduce something like what he was describing
this morning, and tracked it down to a silly mistake in 6895.

On Tue, Jun 07, 2016 at 10:43:06PM -0400, Chris Pavlina wrote:
> This patch adds a zoom-to-selection tool to the eeschema, libedit, pcbnew, and
> modedit canvases, both legacy and GAL. It is my planned replacement for the
> middle-button zoom that only works on legacy, as discussed earlier.
> 
> Because this patch only adds features, and relatively small ones, I'm going to
> go ahead and push it tomorrow - just wanted to give everybody a heads-up since
> it does touch a lot of files. I do want to push it in though to get some
> testing exposure.
> 
> Please let me know if you have any issues, other than ones mentioned below.
> 
> Known issues, to be addressed:
> 
> - OSX has a centering problem. This isn't stricly in my new code, but in old
>   code I'm calling. I'm going to have an OSX box of my own by the end of the
>   week (got it specifically for kicad development :), so I'll look into it then
>   - though if anyone else sees what the problem is, feel free to beat me to it
>   ;)
> 
> - The vertical toolbar is getting a bit long, particularly in eeschema. I'm
>   going to let this be for now, since I still plan to address this in the
>   future. Simon Wells has a patch in the pipeline that adds a menu to the
>   toolbars to hold any icons that don't fit, which should work well as an
>   interim fix until I can get around to fixing the "too damn many buttons"
>   issue at the root.
> 
> - I'm not too fond of the default hotkey ('@'), but we're a bit short on new
>   default hotkeys...
> 
> - Doesn't work in gerbview or pl_editor. These tools have very different UIs
>   from the others and it was nontrivial to patch them in. I'll look at adding
>   it to them as well, which may require a bit of effort to unify block behavior
>   between them a bit.
> 
> -- 
> Chris



References