kicad-developers team mailing list archive

Thread
Date

Re: [PATCH 10/16] Replace unshared boost::shared_array with std::unique_ptr

To: Simon Richter <Simon.Richter@xxxxxxxxxx>, <kicad-developers@xxxxxxxxxxxxxxxxxxx>
From: Maciej Sumiński <maciej.suminski@xxxxxxx>
Date: Wed, 8 Jun 2016 09:44:00 +0200
Authentication-results: spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
In-reply-to: <1465329267-29464-11-git-send-email-Simon.Richter@hogyros.de>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

Thank you Simon, committed in 6902.

Regards,
Orson

On 06/07/2016 09:54 PM, Simon Richter wrote:
> 
> These are never shared, so std::unique_ptr works fine, and std::unique_ptr
> has a specialisation for array types that uses "operator delete[]", so this
> is still correct.
> ---
>  common/gal/opengl/opengl_gal.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Attachment: signature.asc
Description: OpenPGP digital signature

References

[PATCH 00/16] Simple patches
From: Simon Richter, 2016-06-07
[PATCH 01/16] Fix spelling "propage" -> "propagate"
From: Simon Richter, 2016-06-07
[PATCH 02/16] Add missing dependency github_plugin -> pcbcommon
From: Simon Richter, 2016-06-07
[PATCH 03/16] Clarify ERC: we're iterating netlist items, not nets
From: Simon Richter, 2016-06-07
[PATCH 04/16] Explain how ERC works.
From: Simon Richter, 2016-06-07
[PATCH 05/16] Cache netlist item during ERC
From: Simon Richter, 2016-06-07
[PATCH 06/16] Check sorting of netlist during ERC
From: Simon Richter, 2016-06-07
[PATCH 07/16] Kill unused NETLIST_EXPORTER_GENERIC::writeListOfNets
From: Simon Richter, 2016-06-07
[PATCH 08/16] Drop extra copy ctors from IFSG_NODE
From: Simon Richter, 2016-06-07
[PATCH 09/16] Replace boost::shared_ptr with std::shared_ptr
From: Simon Richter, 2016-06-07
[PATCH 10/16] Replace unshared boost::shared_array with std::unique_ptr
From: Simon Richter, 2016-06-07