kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 6/28/2016 6:37 PM, Michael Steinberg wrote:
> Hello,
> I removed the "auto" usage, added @todo's and tried to comply with the
> coding style. If there's anything noncompliant left I'd appreciate a
> pointer!

This:

    if( m_common_settings ) {
        m_common_settings->Flush();
        m_common_settings.reset();
    }

should be:

    if( m_common_settings )
    {
        m_common_settings->Flush();
        m_common_settings.reset();
    }

The opening curly bracket should be on the next line.  I didn't notice
anything else.

You will still need to address JP's concerns before I apply this patch.

> 
> Michael
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>