← Back to team overview

kicad-developers team mailing list archive

Re: PATCH: pcbnew Design Rules actual position value correct save

 

thanks for info Simon, sorry this is my first patch.

Brano


On 12/07/16 20:37, Simon Wells wrote:
Might be easier if you attach patches rather than inline them

thanks

On Wed, Jul 13, 2016 at 6:30 AM, Brano Panak <bpanak@xxxxxxxxx> wrote:
Hi,

this is patch for pcbnew design rules dialog. Solving problem with saving
value at actual position in dialogue when hitting OK. Reported as bug
#1592767.
I tested this on OSX, could somebody please test this on other platforms?
regards
Brano

=== modified file 'pcbnew/dialogs/dialog_design_rules.cpp'
--- pcbnew/dialogs/dialog_design_rules.cpp    2016-06-29 15:09:55 +0000
+++ pcbnew/dialogs/dialog_design_rules.cpp    2016-07-12 18:19:23 +0000
@@ -625,6 +625,7 @@

  bool DIALOG_DESIGN_RULES::TransferDataFromWindow()
  {
+        m_grid->SaveEditControlValue();
      if( !wxDialog::TransferDataFromWindow() )
          return false;


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

=== modified file 'pcbnew/dialogs/dialog_design_rules.cpp'
--- pcbnew/dialogs/dialog_design_rules.cpp	2016-06-29 15:09:55 +0000
+++ pcbnew/dialogs/dialog_design_rules.cpp	2016-07-12 18:19:23 +0000
@@ -625,6 +625,7 @@
 
 bool DIALOG_DESIGN_RULES::TransferDataFromWindow()
 {
+		m_grid->SaveEditControlValue();
     if( !wxDialog::TransferDataFromWindow() )
         return false;
 


Follow ups

References