kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

While this patch may solve the problem, I'm not sure it is ideal.  You
are effectively deciding for the user that they are done editing the
current grid cell irregardless of whether or not that is true.  The
behavior you are attempting to "correct" is inherent in all grid
controls.  As long as a grid cell is being edited, the value for that
cell is not updated until the users hits the enter or tab key.  I'm not
saying no, I'm saying is this the correct way to resolve this issue?

On 7/12/2016 2:45 PM, Brano Panak wrote:
> thanks for info Simon, sorry this is my first patch.
> 
> Brano
> 
> 
> On 12/07/16 20:37, Simon Wells wrote:
>> Might be easier if you attach patches rather than inline them
>>
>> thanks
>>
>> On Wed, Jul 13, 2016 at 6:30 AM, Brano Panak <bpanak@xxxxxxxxx> wrote:
>>> Hi,
>>>
>>> this is patch for pcbnew design rules dialog. Solving problem with
>>> saving
>>> value at actual position in dialogue when hitting OK. Reported as bug
>>> #1592767.
>>> I tested this on OSX, could somebody please test this on other
>>> platforms?
>>> regards
>>> Brano
>>>
>>> === modified file 'pcbnew/dialogs/dialog_design_rules.cpp'
>>> --- pcbnew/dialogs/dialog_design_rules.cpp    2016-06-29 15:09:55 +0000
>>> +++ pcbnew/dialogs/dialog_design_rules.cpp    2016-07-12 18:19:23 +0000
>>> @@ -625,6 +625,7 @@
>>>
>>>   bool DIALOG_DESIGN_RULES::TransferDataFromWindow()
>>>   {
>>> +        m_grid->SaveEditControlValue();
>>>       if( !wxDialog::TransferDataFromWindow() )
>>>           return false;
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>